| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: B-Tree support function number 3 (strxfrm() optimization) |
| Date: | 2015-01-19 22:43:45 |
| Message-ID: | CAM3SWZQ_TUyTP_=eDRoqk3UrA3RBP0BOpkAm=M+QSM=ymQFWgA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 19, 2015 at 12:33 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> All right, it seems Tom is with you on that point, so after some
> study, I've committed this with very minor modifications. Sorry for
> the long delay.
Thank you very much for your help with this! I appreciate it.
> I have not committed the 0002 patch, though, because
> I haven't studied that enough yet to know whether I think it's a good
> idea. Perhaps that could get its own CommitFest entry and thread,
> though, to separate it from this exceedingly long discussion and make
> it clear exactly what we're hoping to gain by that patch specifically.
I'll think about that some more. It might be that we're chasing
diminishing returns there.
It appears that the buildfarm animal brolga isn't happy about this
patch. I'm not sure why, since I thought we already figured out bugs
or other inconsistencies in various strxfrm() implementations.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2015-01-19 23:06:04 | Re: PATCH: Reducing lock strength of trigger and foreign key DDL |
| Previous Message | Magnus Hagander | 2015-01-19 21:54:35 | Re: New CF app deployment |