From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Anssi Kääriäinen <anssi(dot)kaariainen(at)thl(dot)fi>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: INSERT ... ON CONFLICT {UPDATE | IGNORE} |
Date: | 2014-12-16 07:06:01 |
Message-ID: | CAM3SWZQTqsCLZ1YJ1OuWFpO-GmFHwtgwTOg+o_NNzxrPa7Cx4A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Dec 15, 2014 at 4:59 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Mon, Dec 15, 2014 at 4:22 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>> Also, in both Linux and MinGW under option 1 patch I get an OID conflict on
>> OID 3261.
>
> I'll take a pass at fixing this bitrot soon. I'll follow Tom's advice
> about macro collisions on MinGW while I'm at it, since his explanation
> seems plausible.
Attached pair of revised patch sets fix the OID collision, and
presumably fix the MinGW issue (because IGNORE_P is now used as a
token name). It also polishes approach #2 to value locking in a few
places (e.g. better comments). Finally, both patches have a minor
buglet around EXPLAIN ANALYZE output fixed -- the output now indicates
if tuples are pulled up from auxiliary update nodes.
--
Peter Geoghegan
Attachment | Content-Type | Size |
---|---|---|
v1.7.vallock1.tar.gz | application/x-gzip | 90.0 KB |
v1.7.vallock2.tar.gz | application/x-gzip | 76.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2014-12-16 07:28:14 | Re: pg_basebackup vs. Windows and tablespaces |
Previous Message | Pavel Stehule | 2014-12-16 06:57:45 | Re: moving Orafce from pgFoundry - pgFoundry management |