| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal: Log inability to lock pages during vacuum |
| Date: | 2014-11-06 23:40:18 |
| Message-ID: | CAM-w4HOxRBB8ps1PNQSZkNoq6dyRfsqmMNG5dXfFGypCSvGc2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 6, 2014 at 9:30 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> I think the retry logical is a largely pointless complication of already
> complex enough code. You're fixing a problem for which there is
> absolutely no evidence of its existance. Yes, this happens
> occasionally. But it's going to be so absolutely minor in comparison to
> just about every other source of bloat.
I agree bloat isn't really a threat, but what about the relfrozenxid?
If we skip even one page we don't get to advance it and retrying could
eliminate those skipped pages and allow us to avoid a vacuum freeze
which can be really painful. Of course that only works if you can be
sure you haven't overflowed and forgotten any skipped pages and if you
don't find the page still pinned every time until you eventually give
up on it.
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2014-11-07 01:03:20 | Re: Proposal: Log inability to lock pages during vacuum |
| Previous Message | Michael Paquier | 2014-11-06 23:30:51 | Re: split builtins.h to quote.h |