Re: WIP patch for consolidating misplaced-aggregate checks

From: Greg Stark <stark(at)mit(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP patch for consolidating misplaced-aggregate checks
Date: 2012-08-10 16:57:25
Message-ID: CAM-w4HOZ0aamuyunbLSHd_55iULM9_G5cG9dzA+vu39Y+c+oNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 9, 2012 at 5:40 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fair enough. I was not sold on doing that either. I would still like
> to know if it's okay to use one string with %s for the cases where
> there's not a good reason for the "context" to be more than just a
> SQL keyword.

Given that the SQL keyword is going to be an English word I can't
imagine how this could be a big deal for translators. It might not
match gender or case or something but only if the reader is
automatically mentally translating the keyword into their language and
then applying that language's rules to it. At least to me it makes
sense to refer to "VALUES" as a singular noun or "LIMIT" as a generic
male noun even though "limitation" would be feminine (I had to look
that one up though so perhaps I'm not the best person to judge).

--
greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Doug Coleman 2012-08-10 17:14:05 macports and brew postgresql --universal builds
Previous Message Fujii Masao 2012-08-10 16:39:55 Re: bug of pg_trgm?