| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Keith Fiske <keith(at)omniti(dot)com>, Marko Tiikkaja <pgmail(at)joh(dot)to>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump --pretty-print-views |
| Date: | 2014-04-29 17:37:03 |
| Message-ID: | CAM-w4HMyxhHNQyaqurm=25V6+kaYj3_9o9OibbAb5yxtG=9Lgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Huh, I had assumed this was old behaviour. I didn't realize this was
new with 9.3.
Considering the thread "pg_get_viewdefs() indentation considered
harmful" I'm beginning to think this was a regression. It results in
some dump files being unnecessarily large and the pg_dump consuming
too much memory and crashing.
Tom liked my suggestion of doing the indentation modulo 40. There are
plenty of other suggestions that can work too, giving up on
indentation after an indent of 40, switching to an indent distance of
1 if it's more than 10 levels deep, and so on. I think it doesn't
really matter which we choose but we have to do something. And given
this is new behaviour in 9.3 perhaps it should be backported too.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-04-29 18:11:35 | Re: pg_dump --pretty-print-views |
| Previous Message | Tom Lane | 2014-04-29 17:32:50 | Re: What about a castNode() macro? |