From: | Vik Reykja <vikreykja(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: DEALLOCATE IF EXISTS |
Date: | 2012-11-09 16:09:51 |
Message-ID: | CALDgxVteNDvaJjLELFixwW93XoXOcU1wApkYBCw0X_nea23bzg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Oct 9, 2012 at 4:44 PM, Vik Reykja <vikreykja(at)gmail(dot)com> wrote:
> On Tue, Oct 9, 2012 at 4:09 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> =?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= <slardiere(at)hi-media(dot)com> writes:
>> > Indeed, brackets was not correct, it's better now (I think), and correct
>> > some comments.
>>
>> Still wrong ... at the very least you missed copyfuncs/equalfuncs.
>> In general, when adding a field to a struct, it's good practice to
>> grep for all uses of that struct.
>>
>
> I don't see Sébastien's message, but I made the same mistake in my patch.
> Another one is attached with copyfuncs and equalfuncs. I did a grep for
> DeallocateStmt and I don't believe I have missed anything else.
>
> Also, I'm changing the subject so as not to hijack this thread any further.
>
>
>
I am taking no comments to mean no objections and have added this to the
next commitfest.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-11-09 16:27:41 | Re: TRUNCATE SERIALIZABLE and frozen COPY |
Previous Message | Kevin Grittner | 2012-11-09 16:03:05 | Re: TRUNCATE SERIALIZABLE and frozen COPY |