Re: patch to add \watch to psql

From: Will Leinweber <will(at)heroku(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Daniel Farina <daniel(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
Subject: Re: patch to add \watch to psql
Date: 2013-04-05 00:27:05
Message-ID: CAL8LqZSeysTceoSqJPTmHK1TiqcWhx3vf134SAL2F5p6JEnvug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 4, 2013 at 5:04 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>
> I whacked this around some more, added basic docs, and committed it.
>
>
Thanks!

> > Unfortunately rl_clear_screen() is not included at all in libedit,
> causing
> > compilation to fail, and I was completely unable to find a way to
> > distinguish libedit from readline on OS X. It tries extraordinarily hard
> to
> > pretend that it's readline. Instead falling back to simple control
> > characters to clear the screen worked very well on both linux and OS X.
>
> I took that out; "works on the two cases I tried" does not mean "portable".
>

Completely understandable.

I'm very excited to have helped contribute something, however small this
was, to the project.

Thanks again,
Will

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2013-04-05 00:31:16 Re: corrupt pages detected by enabling checksums
Previous Message Tom Lane 2013-04-05 00:04:08 Re: patch to add \watch to psql