From: | Jon Nelson <jnelson+pgsql(at)jamponi(dot)net> |
---|---|
To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |
Date: | 2013-06-17 04:53:21 |
Message-ID: | CAKuK5J2O7SjiyuZHdE62=N3xL2vSYQVLOU7eFXjeuFsi8Pk6hw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jun 16, 2013 at 9:59 PM, Jon Nelson <jnelson+pgsql(at)jamponi(dot)net> wrote:
> On Fri, Jun 14, 2013 at 12:06 PM, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>> On Sat, 2013-05-25 at 13:55 -0500, Jon Nelson wrote:
..
>> * You check for the presence of posix_fallocate at configure time, but
>> don't #ifdef the call site. It looks like you removed this from the v2
>> patch, was there a reason for that? Won't that cause build errors for
>> platforms without it?
>
> Indeed! I believe I have corrected the error and will be sending out a
> revised patch (v5), once the performance and back-testing have
> completed.
Please find attached v5 of the patch, with the above correction in place.
The only change from the v4 patch is wrapping the if
(wal_use_fallocate) block in an #ifdef USE_POSIX_FALLOCATE.
Thanks!
--
Jon
Attachment | Content-Type | Size |
---|---|---|
fallocate-v5.patch | application/octet-stream | 7.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2013-06-17 05:33:44 | Re: Patch: UNNEST (and other functions) WITH ORDINALITY |
Previous Message | Jeff Janes | 2013-06-17 04:42:21 | Re: pgbench --startup option |