Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist

From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Dave Rolsky <autarch(at)urth(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #7873: pg_restore --clean tries to drop tables that don't exist
Date: 2013-02-21 02:28:42
Message-ID: CAK3UJRFimHstfo5KDqhfDS+1Oq7ji0SLWF-JGRye_LvkKQ8spw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Feb 19, 2013 at 6:00 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> 2013/2/16 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>> 2013/2/16 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>> I think it has come up before. I wouldn't object to a pg_dump option to
>>> add IF EXISTS to all the drop commands (though changing the default
>>> behavior would be more controversial). Don't intend to spend my own
>>> time on it though ...

FYI, it was proposed here:
http://www.postgresql.org/message-id/507AD08C.5020603@dalibo.com

> here is patch, that we use about one year - originally for 9.1 - I did
> port to 9.3

dropdb and dropuser both support a similar option named --if-exists. I
suggest --if-exists instead of --conditional-drops for consistency.
I've only glanced at the patch, but if it makes no sense to use
--conditional-drops (or --if-exists, whatever it ends up being called)
without --clean, then attempting to do so should raise an error.

Josh

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Claude Speed 2013-02-21 08:55:06 Re: new BUG: "postgresql 9.2.3: very long query time"
Previous Message bogdan.magajna 2013-02-20 18:21:20 BUG #7898: mapinfo 11.5.2 connection problem

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2013-02-21 02:32:13 Re: [RFC] indirect toast tuple support
Previous Message Daniel Farina 2013-02-21 00:59:24 Re: Unarchived WALs deleted after crash