| From: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Dave Rolsky <autarch(at)urth(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
| Date: | 2013-07-10 21:42:33 |
| Message-ID: | CAK3UJREth9DVL5U7ewOLQYhXF7EcV5BABFE+pzPQjkPfqbW=vQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Tue, Jul 2, 2013 at 7:47 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> Hello
>
> remastered patch
>
> still there is a issue with dependencies
Several of the issues from my last review [1] seem to still be present
in this patch, such as review notes #1 and #4.
And as discussed previously, I think that the --clean option belongs
solely with pg_restore for custom-format dumps. The way the patch
handles this is rather confusing, forcing the user to do:
$ pg_dump -Fc --clean --if-exists --file=backup.dump ...
and then:
$ pg_restore --clean ... backup.dump (without --if-exists)
to get the desired behavior.
Josh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2013-07-10 22:33:57 | Re: BUG #8291: postgres_fdw does not re-read USER MAPING after change. |
| Previous Message | Alex Lai | 2013-07-10 20:36:51 | Unable to handle error in plperl |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-07-10 22:14:58 | Re: changeset generation v5-01 - Patches & git tree |
| Previous Message | Andres Freund | 2013-07-10 21:33:18 | Re: changeset generation v5-01 - Patches & git tree |