Re: New option for pg_basebackup, to specify a different directory for pg_xlog

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New option for pg_basebackup, to specify a different directory for pg_xlog
Date: 2014-02-10 04:16:28
Message-ID: CAJrrPGex-svNCXcxhdcKsU53Y2SjrSr0pf3x_ct6XhLqREA5HQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 8, 2014 at 12:10 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> On 1/29/14, 7:37 PM, Haribabu Kommi wrote:
> >
> > On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote:
> >
> > On 11/30/13, 6:59 AM, Haribabu kommi wrote:
> > > To detect provided data and xlog directories are same or not, I
> > reused the
> > > Existing make_absolute_path() code as follows.
> >
> > I note that initdb does not detect whether the data and xlog
> directories
> > are the same. I think there is no point in addressing this only in
> > pg_basebackup. If we want to forbid it, it should be done in initdb
> > foremost.
> >
> > Thanks for pointing it. if the following approach is fine for
> > identifying the identical directories
> > then I will do the same for initdb also.
>
> I wouldn't bother. It's a lot of work for little benefit. Any mistake
> a user would make can easily be fixed.

I also felt a lot of work for little benefit but as of now I am not able to
find an easier solution to handle this problem.
can we handle the same later if it really requires?

--
Regards,
Hari Babu
Fujitsu Australia Software Technology

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsubasa Sakamoto 2014-02-10 04:51:38 Re: client encoding that psql command sets
Previous Message Amit Kapila 2014-02-10 04:10:08 Re: Inconsistency between pg_stat_activity and log_duration