Re: Problem with displaying "wide" tables in psql

From: Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Greg Stark <stark(at)mit(dot)edu>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com>
Subject: Re: Problem with displaying "wide" tables in psql
Date: 2014-04-29 04:07:15
Message-ID: CAJTaR30qTSjMkmciwde4iuqfq_QUgM-RywtGYsQ0Xh8qcQYLWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

rebased

2014-04-29 7:43 GMT+04:00 Michael Paquier <michael(dot)paquier(at)gmail(dot)com>:

> On Tue, Apr 29, 2014 at 12:37 PM, Sergey Muraviov
> <sergey(dot)k(dot)muraviov(at)gmail(dot)com> wrote:
> > 2014-04-29 5:52 GMT+04:00 Peter Eisentraut <peter_e(at)gmx(dot)net>:
> >
> >> Please fix this compiler warning. I think it came from this patch.
> >> print.c: In function 'print_aligned_vertical':
> >> print.c:1354:10: error: pointer targets in passing argument 1 of
> >> 'strlen_max_width' differ in signedness [-Werror=pointer-sign]
> >> encoding);
> >> ^
> >> print.c:126:12: note: expected 'unsigned char *' but argument is of type
> >> 'char *'
> >> static int strlen_max_width(unsigned char *str, int *target_width, int
> >> encoding);
> >> ^
> > fixed
> Your patch has been committed by Greg not so long ago, you should send
> for this warning a patch rebased on the latest master branch commit :)
> --
> Michael
>

--
Best regards,
Sergey Muraviov

Attachment Content-Type Size
fix_psql_print_aligned_vertical_v13.patch text/x-patch 553 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message amul sul 2014-04-29 05:47:46 Re: Different behaviour of concate() and concate operator ||
Previous Message Michael Paquier 2014-04-29 03:43:36 Re: Problem with displaying "wide" tables in psql