Re: Review of pg_archivecleanup -x option patch

From: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Greg Smith <greg(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review of pg_archivecleanup -x option patch
Date: 2012-03-28 16:13:34
Message-ID: CAJKUy5ijJE_xbZq91YzZSgN73uULQ9ppjPvog4-7ca+6ck0Rjw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 28, 2012 at 8:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>>
>>> $ ./pg_archivecleanup -x "bz2" /tmp 000000010000000100000058
>>
>> Hmm, but I thought that the idea was that the extension was optional.
>> Perhaps I'm missing something but I don't think the previous patch
>> will complain about that either; or at least I don't see why the
>> behavior should be any different.
>
> Can someone enlighten me on this point?
>

mmm! you're right... it's not complaining either... i was sure it was...
and i'm not sure i want to contor things for that...

so, just forget my last mail about that... your refactor is just fine for me

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2012-03-28 16:19:35 Re: max_files_per_process ignored on Windows
Previous Message Heikki Linnakangas 2012-03-28 16:12:28 max_files_per_process ignored on Windows