Re: incorrect handling of the timeout in pg_receivexlog

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: incorrect handling of the timeout in pg_receivexlog
Date: 2012-05-25 17:56:27
Message-ID: CAHGQGwHwsPcDaf0SeDokGg5d05yrFqwdJ2bRTCwDe3ATyebpDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 24, 2012 at 4:52 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Wed, May 23, 2012 at 8:11 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Tue, May 22, 2012 at 11:04 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Mon, May 14, 2012 at 2:24 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>> On Fri, May 11, 2012 at 11:43 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>>>> Should we go down the easy way and just reject connections when the flag is
>>>>> mismatching between the client and the server (trivial to do - see the
>>>>> attached patch)?
>>>>
>>>> +       char       *tmpparam;
>>>>
>>>> You forgot to add "const" before "char", which causes a compile-time warning.
>>>
>>> I went ahead and committed this, with this fix and a slight change to
>>> the message text.
>>
>> Thanks!
>>
>>> Hope that's OK with everyone...
>>
>> What about calling PQfinish() before exit() to avoid "unexpected EOF
>> connection" error?
>> Patch attached.
>
> Makes sense, applied.

Thanks! So, let's go back to the original problem: pg_receivexlog
still doesn't work fine
under --disable-integer-datetimes. I previously posted the patch which
fixes that problem.
http://archives.postgresql.org/message-id/CAHGQGwFutqnFPBYcHUCuoy1zMVDXto=o4OgsjrBWxW4zj2TCSw@mail.gmail.com

Attached is the updated version of the patch. Comments?

Regards,

--
Fujii Masao

Attachment Content-Type Size
timeout_handling_v3.patch application/octet-stream 9.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2012-05-25 18:15:02 Re: 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile
Previous Message Sergey Koposov 2012-05-25 17:55:19 Re: 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile