Re: Compression of full-page-writes

On Sat, May 10, 2014 at 8:33 PM, Sameer Thakur <samthakur74(at)gmail(dot)com> wrote:
> Hello,
>>Done. Attached is the updated version of the patch.
> I was trying to check WAL reduction using this patch on latest available git
> version of Postgres using JDBC runner with tpcc benchmark.
>
> patching_problems.txt
> <http://postgresql.1045698.n5.nabble.com/file/n5803482/patching_problems.txt>
>
> I did resolve the patching conflicts and then compiled the source, removing
> couple of compiler errors in process. But the server crashes in the compress
> mode i.e. the moment any WAL is generated. Works fine in 'on' and 'off'
> mode.

What kind of error did you get at the server crash? Assertion error? If yes,
it might be because of the conflict with
4a170ee9e0ebd7021cb1190fabd5b0cbe2effb8e.
This commit forbids palloc from being called within a critical section, but
the patch does that and then the assertion error happens. That's a bug of
the patch.

Regards,

--
Fujii Masao