Re: Bug of pg_receivexlog -v

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug of pg_receivexlog -v
Date: 2014-08-01 16:47:16
Message-ID: CAHGQGwHJjryCV5U3ED8jOF1UUBdO92f9jbZ279vdqRC84zJ70Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 1, 2014 at 8:35 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> Hi,
>
> In 9.2, pg_receivexlog -v has emitted the messages as follows at the
> end of each WAL file.
>
> pg_receivexlog: finished segment at 0/2000000 (timeline 1)
> pg_receivexlog: finished segment at 0/3000000 (timeline 1)
> pg_receivexlog: finished segment at 0/4000000 (timeline 1)
>
> But, while reviewing the pg_receivexlog patch written by Furuya, I
> found that 0b63291 had
> broken this feature, and then now pg_receivexlog -v doesn't emit such
> messages at all.
> Attached patch fixes this problem. This needs to be back-patched to 9.3.

I found another problem on pg_receivexlog, which can cause the leak of
PGresult. The leak is small and rare, but it's better to fix that.
Patch attached.

Regards,

--
Fujii Masao

Attachment Content-Type Size
pgresult-leak.patch text/x-diff 994 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2014-08-01 17:05:21 Re: Proposal: Incremental Backup
Previous Message Anastasia Lubennikova 2014-08-01 16:46:44 Re: Index-only scans for GIST