Re: Broken example in PL/PgSQL documentation

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Marti Raudsepp <marti(at)juffo(dot)org>, Marko Tiikkaja <marko(at)joh(dot)to>, PG Docs <pgsql-docs(at)postgresql(dot)org>
Subject: Re: Broken example in PL/PgSQL documentation
Date: 2014-10-09 18:23:05
Message-ID: CAHGQGwGA5nYH=LPW5g4LN3c1t1nqX1n9qpBOcmYSb1Q6zu_GwQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Fri, Oct 10, 2014 at 2:37 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
>
> 2014-10-08 21:25 GMT+02:00 Marti Raudsepp <marti(at)juffo(dot)org>:
>>
>> On Thu, Sep 4, 2014 at 3:06 PM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
>> > Just came across a broken example in the docs
>>
>> +1. New version works. I would slightly prefer adding an alias to the
>> table:
>>
>> RETURN QUERY SELECT s.quantity, s.quantity * s.price FROM sales AS s
>> WHERE s.itemno = p_itemno;
>>
>> Other than that, there's not much to review here, marking as "Ready
>> for Committer"
>
>
> This last patch is good. I it good fix of this problem - and usage of
> qualified identifiers is common and recommended solution.
>
> It is really ready for commiter.

Applied. Thanks!

Regards,

--
Fujii Masao

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Phil Olson 2014-10-09 21:29:30 Documentation for CREATE USER
Previous Message Pavel Stehule 2014-10-09 17:37:17 Re: Broken example in PL/PgSQL documentation