Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, MauMau <maumau307(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>
Subject: Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]
Date: 2014-08-28 12:22:16
Message-ID: CAHGQGwFb9WqWpqbz_vupCpWf7B7=WEt_XFmqX26g-uiyrCtuTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> comments?

+ fprintf(output, _(" ECHO control what input is
written to standard output [all, queries]\n"));

The valid values in the help messages should be consistent with
the values that the tab-completion displays. So in the case of ECHO,
"errors" and "none" also should be added in the message. Thought?

In the help messages of some psql variables like ECHO_HIDDEN, valid
values are not explained. Why not?

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-08-28 12:28:05 Re: pgsql: Allow units to be specified in relation option setting value.
Previous Message Andres Freund 2014-08-28 12:11:33 Re: pgsql: Allow units to be specified in relation option setting value.