Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.
Date: 2013-05-01 13:55:45
Message-ID: CAHGQGwF7MT5VC=Ybw9Mqp3y+HF3GzWLcQP0y8Me=sA717HO5zQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, May 1, 2013 at 9:20 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 1 May 2013 11:25, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Wed, Apr 24, 2013 at 8:49 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> Make fast promotion the default promotion mode.
>>> Continue to allow a request for synchronous
>>> checkpoints as a mechanism in case of problems.
>>
>> Is there clean way to request synchronous checkpoint at the standby promotion?
>> I'm sure that we can do that by creating the file "promote" and
>> sending the SIGUSR1
>> signal to the postmaster. Or by using previous version of pg_ctl.
>> These are not clean
>> and would confuse users.
>
> I just removed the user interface at Heikki's request, so yes, I can
> see its not ideal interface.
>
> My wish was to have a mechanism should we need it.
>
> A third option would be to not have any way at all.
>
> What is your preference?

My preference is adding something like --full-checkpoint option into
pg_ctl promote.

As far as I understand Heikki's request correctly, he dislikes the
approach reusing
-m option in pg_ctl promote. That is, previous behavior of the promotion is not
"smarter" than current one, but we have to have specified "-m smart" to choose
the previous behavior of the promotion. ISTM that his this request makes sense.

So I'd like to propose to add new option which would not confuse
users, into pg_ctl
promote.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2013-05-01 16:10:30 Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.
Previous Message Simon Riggs 2013-05-01 12:20:58 Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-05-01 14:06:55 Re: In progress INSERT wrecks plans on table
Previous Message Simon Riggs 2013-05-01 12:20:58 Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.