Re: New option for pg_basebackup, to specify a different directory for pg_xlog

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New option for pg_basebackup, to specify a different directory for pg_xlog
Date: 2014-01-31 13:21:37
Message-ID: CAHGQGwEXYwe9W9FBX9MzdcUxSmGNQaUQr21yWj=82VskeHC0aQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 30, 2014 at 9:37 AM, Haribabu Kommi
<kommi(dot)haribabu(at)gmail(dot)com> wrote:
>
> On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote:
>>
>> On 11/30/13, 6:59 AM, Haribabu kommi wrote:
>> > To detect provided data and xlog directories are same or not, I reused
>> > the
>> > Existing make_absolute_path() code as follows.
>>
>> I note that initdb does not detect whether the data and xlog directories
>> are the same. I think there is no point in addressing this only in
>> pg_basebackup. If we want to forbid it, it should be done in initdb
>> foremost.
>
>
> Thanks for pointing it. if the following approach is fine for identifying
> the identical directories
> then I will do the same for initdb also.

I'm feeling the similar way as Peter. And, ISTM that we need much changes of
source though its benefit is small....

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-01-31 13:40:06 Re: pg_basebackup and pg_stat_tmp directory
Previous Message Mitsumasa KONDO 2014-01-31 13:18:07 Re: pg_basebackup and pg_stat_tmp directory