| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Michael Paquier (michael(dot)paquier(at)gmail(dot)com)" <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2015-03-06 03:27:04 |
| Message-ID: | CAHGQGwEP2c0Baf+jmpnZL+p3x5rUBMTeLXqgwNMdQ0PbdktfTw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 5, 2015 at 10:28 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2015-03-05 12:14:04 +0000, Syed, Rahila wrote:
>> Please find attached a patch. As discussed, flag to denote
>> compression and presence of hole in block image has been added in
>> XLogRecordImageHeader rather than block header.
>
> FWIW, I personally won't commit it with things done that way. I think
> it's going the wrong way, leading to a harder to interpret and less
> flexible format. I'm not going to further protest if Fujii or Heikki
> commit it this way though.
I'm pretty sure that we can discuss the *better* WAL format even after
committing this patch.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-03-06 03:44:11 | Re: Table-level log_autovacuum_min_duration |
| Previous Message | Peter Eisentraut | 2015-03-06 03:11:30 | Re: Providing catalog view to pg_hba.conf file - Patch submission |