| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_stat directory and pg_stat_statements |
| Date: | 2014-06-02 13:59:55 |
| Message-ID: | CAHGQGwEH1p2jj4kG33xm0qH0LwLyp7=Dn6A5WvQzv3HGuTbbLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Wed, May 28, 2014 at 10:49 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> You're concerned about the scenario using pg_upgrade? I'm not sure the detail
>> of pg_upgrade. But if it doesn't work properly, we should have gotten
>> the trouble
>
> I'm not worried about pg_upgrade, because by design pg_stat_statements
> will discard stats files that originated in earlier versions. However,
> I don't see a need to change pg_stat_statements to serialize its
> statistics to disk in the pg_stat directory before we branch off 9.4.
> As you mentioned, it's harmless.
Yeah, that's an idea. OTOH, there is no *strong* reason to postpone
the fix to 9.5. So I just feel inclined to apply the fix now...
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-06-02 14:02:53 | Re: Jsonb: jbvBinary usage in the convertJsonbValue? |
| Previous Message | Tom Lane | 2014-06-02 13:58:56 | Re: Re-create dependent views on ALTER TABLE ALTER COLUMN ... TYPE? |