Re: Specifying the unit in storage parameter

On Fri, Aug 8, 2014 at 2:12 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Fujii Masao wrote:
>> On Fri, Aug 8, 2014 at 12:56 PM, Alvaro Herrera
>> <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> > Hm, what's with the parse_int signature change and the hintmsg thing?
>> > Is it just me or the patch is incomplete?
>>
>> Sorry, probably I failed to see your point. You mean that the signature
>> of parse_int needs to be changed so that it includes the hintmsg as the
>> argument? If yes, there is no problem. Both signature and function body
>> of parse_int has already included the hingmsg as the argument so far.
>> Am I missing something?
>
> I just mean that the parse_int function body is not touched by your
> patch, unless I am failing to see something.

Yes, my patch doesn't change the parse_int function at all because I didn't
think such change is required for the purpose (i.e., just allows us to specify
the unit in the setting of storage parameters). But, you might find the
reason why it needs to be changed?

Regards,

--
Fujii Masao