| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, furuyao(at)pm(dot)nttdata(dot)co(dot)jp, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, teranishih(at)nttdata(dot)co(dot)jp |
| Subject: | Re: PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog. |
| Date: | 2014-11-19 05:16:35 |
| Message-ID: | CAHGQGwE9O8WHz6iZb_ODPDn5x2rTBPpWqFoVjraHsW0En4FbhA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 17, 2014 at 12:30 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Mon, Nov 17, 2014 at 10:02 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Sat, Nov 15, 2014 at 9:10 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> Yep, sounds a good thing to do if master requested answer from the
>>> client in the keepalive message. Something like the patch attached
>>> would make the deal.
>>
>> Isn't it better to do this only when replication slot is used?
> Makes sense. What about a check using reportFlushPosition then?
Sounds reasonable. Thanks for updating the patch!
But the patch could not already be applied to the master cleanly
because c4f99d2 heavily changed the code that the patch also touches...
I rewrote the patch and pushed it to both master and REL9_4_STABLE.
Anyway, thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2014-11-19 05:17:10 | Re: pg_receivexlog --status-interval add fsync feedback |
| Previous Message | Amit Kapila | 2014-11-19 03:23:13 | Re: pg_basebackup vs. Windows and tablespaces |