| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, furuyao(at)pm(dot)nttdata(dot)co(dot)jp, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog and replication slots |
| Date: | 2014-08-19 09:02:32 |
| Message-ID: | CAHGQGwE+3Z2o1yZYji8JLTvGHzj9ymKXTmTEHPv==39SNr0FrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 19, 2014 at 5:52 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2014-08-18 14:38:06 +0900, Michael Paquier wrote:
>> - IDENTIFY_SYSTEM checks were incorrect (even in HEAD). The following
>> check was done but in 9.4 this command returns 4 fields:
>> (PQntuples(res) != 1 || PQnfields(res) < 3)
>
> Which is correct. We don't want to error out in the case where 3 columns
> are returned because that'd unnecessarily break compatibility with <
> 9.4. Previously that check was != 3...
>
> This isn't a bug.
Okay, I understood why you didn't update those codes.
Since we don't allow replication between different major versions,
it's better to apply this change at least into libpqwalreceiver.c. Thought?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-08-19 09:03:55 | Re: pg_receivexlog and replication slots |
| Previous Message | Andres Freund | 2014-08-19 08:52:14 | Re: pg_receivexlog and replication slots |