Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

From: Claudio Freire <klaussfreire(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal
Date: 2013-07-06 15:58:01
Message-ID: CAGTBQpa0hk=wfwXtJLp035E=EvzhKmSOq1djCvwEuaUiWorEwA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Look at that:

return x
$$ LANGUAGE plpythonu;
SELECT * FROM test_type_conversion_numeric(100);
! INFO: (Decimal('100'), 'Decimal')
CONTEXT: PL/Python function "test_type_conversion_numeric"
test_type_conversion_numeric
------------------------------
--- 219,225 ----
return x
$$ LANGUAGE plpythonu;
SELECT * FROM test_type_conversion_numeric(100);
! INFO: (Decimal("100"), 'Decimal')
CONTEXT: PL/Python function "test_type_conversion_numeric"
test_type_conversion_numeric
------------------------------

" instead of '

All the more reason to use as_tuple

On Sat, Jul 6, 2013 at 9:16 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 07/06/2013 01:52 AM, Claudio Freire wrote:
>>
>> On Sat, Jul 6, 2013 at 2:39 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>
>>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>>>
>>>> PL/Python: Convert numeric to Decimal
>>>
>>> Assorted buildfarm members don't like this patch.
>>
>>
>> Do you have failure details?
>>
>> This is probably an attempt to operate decimals vs floats.
>>
>> Ie: Decimal('3.0') > 0 works, but Decimal('3.0') > 1.3 doesn't
>> (decimal is explicitly forbidden from operating on floats, some design
>> decision that can only be disabled in 3.3).
>>
>>
>
>
> Instead of speculating, you can actually see for yourself. The dashboard is
> at <http://www.pgbuildfarm.org/cgi-bin/show_status.pl> Pick one of the
> machines failing at PLCheck-C and click its 'Details' link. Then scroll down
> a bit and you'll see what is failing.
>
> cheers
>
> andrew
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Meskes 2013-07-06 20:14:11 pgsql: Also escape double quotes for ECPG's #line statement.
Previous Message Tom Lane 2013-07-06 15:17:04 pgsql: Rename a function to avoid naming conflict in parallel regressio

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Alan Dorman 2013-07-06 16:07:37 A mailing-list based bug tracker
Previous Message Noah Misch 2013-07-06 14:55:22 Re: Have REFRESH MATERIALIZED VIEW run as the MV owner