Re: pg_stat directory and pg_stat_statements

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_stat directory and pg_stat_statements
Date: 2014-05-29 06:26:45
Message-ID: CAG7mmoxvDUkSjOpH7roHOEssdooXxftLyqDw6utCONg2q7yH6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 29, 2014 at 11:32 AM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:

> On Wed, May 28, 2014 at 10:49 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
> wrote:
> > You're concerned about the scenario using pg_upgrade?
>
Yeah - I was.

> I'm not sure the detail
> > of pg_upgrade. But if it doesn't work properly, we should have gotten
> > the trouble
>
> I'm not worried about pg_upgrade, because by design pg_stat_statements
> will discard stats files that originated in earlier versions. However,
> I don't see a need to change pg_stat_statements to serialize its
> statistics to disk in the pg_stat directory before we branch off 9.4.
> As you mentioned, it's harmless.
>
K.
I was just curious about the scenario.
If it was discarding the stats files that originated in earlier version, It
should be ok.

--

Thanks & Regards,
Ashesh Vashi

>
> --
> Peter Geoghegan
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-05-29 10:09:43 Re: Ancient bug in formatting.c/to_char()
Previous Message Peter Geoghegan 2014-05-29 06:02:27 Re: pg_stat directory and pg_stat_statements