Re: Add more regression tests for CREATE OPERATOR

From: Szymon Guz <mabewlun(at)gmail(dot)com>
To: Robins Tharakan <tharakan(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add more regression tests for CREATE OPERATOR
Date: 2013-06-17 10:19:40
Message-ID: CAFjNrYtJSwhM-GFmP-+3nfDOmUG84oiBJDXDH-MQRQD4XHvjkg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23 May 2013 00:34, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:

> Hi,
>
> Please find attached a patch to take code-coverage of CREATE OPERATOR
> (src/backend/commands/operatorcmds.c) from 56% to 91%.
>
> Any and all feedback is welcome.
> --
> Robins Tharakan
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>
Hi,
there is one commented out test. I think it should be run, or deleted.
There is no use of commented sql code which is not run.

What do you think?

regards,
Szymon

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2013-06-17 10:34:52 Re: MD5 aggregate
Previous Message Dimitri Fontaine 2013-06-17 09:41:32 Re: [PATCH] Remove useless USE_PGXS support in contrib