| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, "Robert Haas *EXTERN*" <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: poll: CHECK TRIGGER? |
| Date: | 2012-03-08 22:00:29 |
| Message-ID: | CAFj8pRDgjGO2f_fy5TiTwASAj18t9M75gCH0XG99JHs3co2PqA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2012/3/8 Peter Eisentraut <peter_e(at)gmx(dot)net>:
> On tor, 2012-03-08 at 10:49 +0100, Albe Laurenz wrote:
>> Actually, I did when I reviewed the patch the first time round.
>> I think that the checks implemented are clearly good and useful,
>> since any problem reported will lead to an error at runtime if
>> a certain code path in the function is taken.
>
> Shouldn't the validator just reject the function in those cases?
>
Validator check syntax only (and cannot do more, because there should
not be dependency between functions). But it doesn't verify if table
exists, if table has refereed columns, if number of expressions in
raise statement is equal to number of substitute symbols ...
Regards
Pavel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2012-03-08 22:04:05 | Re: PGXS ignores SHLIB_LINK when linking modules |
| Previous Message | Peter Eisentraut | 2012-03-08 21:59:59 | Re: pg_upgrade --logfile option documentation |