Re: Built-in binning functions

Hi

I did a review of last patch

1. There is no problem with patching
2. compilation and doc compilation without warnings and issues.
3. code is clean, respects Postgres coding rules and is well documented -
it is slightly modified Tom's version with float8 optimization
4. The name with_bucket is probably one with wide agreement
5. There are a basic set of tests for muttable or fixed sized types

I found only one issue - float8 path has no own test in regress tests. When
this issue will be fixed, I will mark this patch as ready for commit

Regards

Pavel

2014-09-01 21:29 GMT+02:00 Petr Jelinek <petr(at)2ndquadrant(dot)com>:

> On 01/09/14 01:42, Tom Lane wrote:
>
>>
>> BTW, was there a reason for not noticing the case of exact match in
>> the search loop, and falling out early? As it stands the code will
>> reliably choose the leftmost match if there are multiple equal items
>> in the search array, but do we care about such cases?
>>
>>
> I am not sure if we care, probably not.
>
> Anyway I attached patch that I am happy with. I am not yet sure what to do
> with naming.
>
>
> --
> Petr Jelinek http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>
>