From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: review: CHECK FUNCTION statement |
Date: | 2011-12-14 06:33:03 |
Message-ID: | CAFj8pRDCbsqjRwC45ZQ-6LSFvMF2pv7b+6Hgu4u3=QO0yJ2BLA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello
2011/12/12 Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>:
> Pavel Stehule wrote:
>> there is merged patch
>
> Works fine, except that there are still missing const qualifiers
> in copyfuncs.c and equalfuncs.c that lead to compiler warnings.
>
> One thing I forgot to mention:
> I thought there was a consensus to add a WITH() or OPTIONS() clause
> to pass options to the checker function:
> http://archives.postgresql.org/message-id/12568.1322669638@sss.pgh.pa.us
>
> I think this should be there so that the API does not have to be
> changed in the future.
>
changes:
* fixed warnings
* support for options - actually only two options are supported -
quite and fatal_errors
these options are +/- useful - main reason for their existence is
testing of support of options - processing on CHECK ... stmt side and
processing on checker function side.
options are send as 2d text array - some like
'{{quite,on},{fatal_errors,on}} - so direct call of checker function
is possible
* regress test for multi check
Regards
Pavel
> Yours,
> Laurenz Albe
Attachment | Content-Type | Size |
---|---|---|
check_function-2011-12-14-1.diff.gz | application/x-gzip | 26.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Shigeru Hanada | 2011-12-14 06:34:08 | Re: WIP: Collecting statistics on CSV file data |
Previous Message | Thomas Munro | 2011-12-14 05:27:45 | Re: NOTIFY with tuples |