Re: review: Non-recursive processing of AND/OR lists

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: Non-recursive processing of AND/OR lists
Date: 2013-06-30 15:46:37
Message-ID: CAFj8pRCNuq=Z+pk-O90-emeDan-uv1O8ja0Mv_TebPGfDWOtWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2013/6/30 Gurjeet Singh <gurjeet(at)singh(dot)im>:
> On Sun, Jun 30, 2013 at 11:13 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
>>
>> Hello
>>
>> just one small notices
>>
>> I dislike a name "root_bool_expr", because, there is not a expression,
>> but expression type. Can you use "root_bool_expr_type" instead? It is
>> little bit longer, but more correct. Same not best name is
>> "root_char", maybe "root_bool_op_name"
>>
>> or root_expr_type and root_op_name ???
>
>
> How about naming those 3 variables as follows:
>
> root_expr_kind
> root_expr_name
> root_bool_expr_type

+1

Pavel

>
>
> --
> Gurjeet Singh
>
> http://gurjeet.singh.im/
>
> EnterpriseDB Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gurjeet Singh 2013-06-30 16:35:24 Re: review: Non-recursive processing of AND/OR lists
Previous Message Robins Tharakan 2013-06-30 15:46:20 Re: New regression test time