Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Satoshi Nagayasu <snaga(at)uptime(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Dave Rolsky <autarch(at)urth(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Date: 2013-10-24 15:36:37
Message-ID: CAFj8pRCJJmsnaKjY4oOAKBd3--hSCkeAHf=5e=D+ff2mDUi-2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

2013/10/24 Robert Haas <robertmhaas(at)gmail(dot)com>

> On Tue, Oct 22, 2013 at 9:37 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com>
> wrote:
> > On Mon, Oct 14, 2013 at 5:38 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com>
> wrote:
> >> Also, Pavel, this patch is still listed as 'Needs Review' in the CF
> >> app, but I haven't seen a response to the concerns in my last message.
> >
> > It looks like this patch has been imported into the 2013-11 CF [1] and
> > marked "Needs Review". I looked at the version of the patch pointed to
> > in that CF entry back in July, and noted [2] several problems that
> > still seemed to be present in the patch, for which I never saw a
> > followup from Pavel. IMO this patch should have gotten marked
> > "Returned with Feedback" pending a response from Pavel.
>
> That sounds reasonable to me. Perhaps you should so mark it.
>

+1

Regards

Pavel

>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2013-10-24 15:58:36 Re: random() generates collisions too early
Previous Message Robert Haas 2013-10-24 15:05:23 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-10-24 15:37:33 Re: Compression of full-page-writes
Previous Message Robert Haas 2013-10-24 15:07:38 Re: Compression of full-page-writes