Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: MauMau <maumau307(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Petr Jelinek <petr(at)2ndquadrant(dot)com>
Subject: Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]
Date: 2014-06-26 13:35:44
Message-ID: CAFj8pRBuY_-EGK2gDHP4yxJVZWEvozeisUPgEr+yZuG4Zo7E4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-06-26 15:26 GMT+02:00 MauMau <maumau307(at)gmail(dot)com>:

> Hello,
>
> From: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
>
>> fixed
>>
>
> Thank you. All is fine.
>
>
>
> should be ""Environment variables". And this section lacks description
>>> for Windows, such as:
>>>
>>> + printf(_(" NAME=VALUE [NAME=VALUE] psql ...\n or \\setenv NAME
>>> [VALUE]
>>> in interactive mode\n\n"));
>>>
>>> + printf(_(" PGPASSFILE password file (default ~/.pgpass)\n"));
>>>
>>>
>> ??? -
>>
>
> I meant that how to set environment variables on Windows command prompt is
> different from on UNIX/Linux, and the default password file path is also
> different on Windows. Do we describe them in this help?
>

hmm, I'll check it

Pavel

>
>
> Lastly, to follow most of your descriptions, "s" at the end of the first
> verb in these messages should be removed. For example, use "set" instead
> of "sets".
>
>
> + printf(_(" COMP_KEYWORD_CASE determines which letter case to use when
> completing an SQL key word\n"));
> + printf(_(" columns sets the target width for the wrapped
> format\n"));
> + printf(_(" linestyle sets the border line drawing style
> [ascii, old-ascii, unicode]\n"));
> + printf(_(" recordsep specifies the record (line) separator to
> use in unaligned output format\n"));
> + printf(_(" title sets the table title for any subsequently
> printed tables\n"));
>
>
> This is all I noticed in the review.
>
>
> Regards
> MauMau
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-06-26 13:46:29 Re: pgaudit - an auditing extension for PostgreSQL
Previous Message MauMau 2014-06-26 13:26:01 Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]