Re: review: psql and pset without any arguments

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Marc Mamin <M(dot)Mamin(at)intershop(dot)de>
Subject: Re: review: psql and pset without any arguments
Date: 2013-09-29 17:53:23
Message-ID: CAFj8pRB-CE-_hFmf8efOisMvpv10v9KQGft=yjidUYTsjjOeug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Pavel
>
>
> Hello,
>
> Sorry for the delay, here is the new patch. The \pset output will look
> like follow:
>
> postgres=# \pset
>
> Border style (border) is 1.
> Target width (columns) unset.
>
> Expanded display (expanded) is off.
> Field separator (fieldsep) is "|".
> Default footer (footer) is on.
> Output format (format) s aligned.
> Line style (linestyle) is ascii.
>
> Null display (null) is "".
> Locale-adjusted numeric output (numericlocale) is off.
>
> Pager (pager) is used for long output.
> Record separator (recordsep) is <newline>.
> Table attributes (tableattr) unset.
> Title (title) unset.
>
> Tuples only (tuples_only) is off.
>
> postgres=# \pset null #
> Null display (null) is "#".
> postgres=#
>
>
> This also mean that all translation strings of those messages should be
> updated.
>
> If we don't want to modify those messages, I can provide an other patch
> which print output as follow:
>
> postgres=# \pset
> border: Border style is 1.
> columns: Target width unset.
> expanded: Expanded display is off.
> fieldsep: Field separator is "|".
> footer: Default footer is on.
> format: Output format is aligned.
> linestyle: Line style is ascii.
> null: Null display is "".
> numericlocale: Locale-adjusted numeric output is off.
> pager: Pager is used for long output.
> recordsep: Record separator is <newline>.
> tableattr: Table attributes unset.
> title: Title unset.
> tuples_only: Tuples only is off.
>
> postgres=# \pset null #
> Null display is "#".
> postgres=#
>
> I think the first output is better but it need translation work. Let me
> know.
>
>
I prefer first output too

Regards

Pavel

>
> Regards,
>
> --
> Gilles Darold
> Administrateur de bases de donnéeshttp://dalibo.com - http://dalibo.org
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nicholas White 2013-09-29 20:32:21 Re: Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls
Previous Message Steve Singer 2013-09-29 17:46:44 Re: record identical operator - Review