Re: review - pg_stat_statements

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Subject: Re: review - pg_stat_statements
Date: 2013-12-02 04:37:54
Message-ID: CAFj8pRAVs2aGZbczG_yRSu6-ixDxN3atz5OnAPwqNuiC2wRSfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

I waited to fix.

Now I marked patch as ready for committer

Regards

Pavel

2013/12/1 Peter Geoghegan <pg(at)heroku(dot)com>

> On Sat, Nov 30, 2013 at 11:30 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> > After this fix it should be ready for commit
>
> Version with trivial, single token fix attached. I'm not sure if you
> just forgot to mark this "ready for committer" in the commitfest app,
> but if not you'll want to do so now.
>
> I defer to the judgement of a committer here -- my hope is that the
> queryid-exposing patch will be committed soon, and so it becomes a
> simple matter of "rebasing" (a term I use loosely) what I've done here
> on top of the then master branch. I felt that I had an up-front
> responsibility to not regress the aggressive-snapshot-aggregating use
> case, which is why I haven't simply waited for the queryid patch to be
> committed so that I could only then submit a new patch (a *separate*
> patch that allows query texts to not be returned when unneeded).
>
> Thanks
> --
> Peter Geoghegan
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-12-02 04:55:51 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Previous Message Stephen Frost 2013-12-02 03:47:20 Re: Extension Templates S03E11