Re: no test programs in contrib

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: no test programs in contrib
Date: 2014-11-26 14:30:20
Message-ID: CAFcNs+rAUpTph8w0L8h3g0k51VhZ445=3WHT=fxnAUGPTrY+iA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 26, 2014 at 12:27 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
>
> Here's a patch. This creates a new subdir src/test/modules and places
> the five initially proposed modules in there. They continue to have
> their makefile with the same ifdef USE_PGXS pattern; they are no longer
> installed by default.
>
> Because many of them had either "test" in their names or some other
> now-useless particle, I renamed them:
>
> worker_spi -> bgworker
> test_decoding -> logical_decoding
> dummy_seclabel -> seclabel
> test_shm_mq -> shm_mq
> test_parser -> tsparser
>
> The renaming is not complete: the extensions continue to have the old
> names, for instance. If the consensus is to rename them completely I
> can finish that, or we can decide to keep the original names, but they
> all seem inappropriate to me.
>
> I haven't done anything about documentation. I thought a new chapter
> after "Additional Supplied Modules", perhaps entitled "Additional Sample
> Modules" would be appropriate.
>
> I tweaked make targets check, installcheck, installcheck-world,
> check-world: they all run the additional tests now. For buildfarm, the
> client code will need to be updated to have a new stage for
> src/test/modules running "make check".
>
> I haven't touched MSVC yet.
>
> Opinions on this approach please?
>

The patch is missing...

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-11-26 14:32:55 Re: no test programs in contrib
Previous Message Robert Haas 2014-11-26 14:29:13 Re: no test programs in contrib