Re: CREATE IF NOT EXISTS INDEX

On Thu, Oct 2, 2014 at 9:55 PM, Marti Raudsepp <marti(at)juffo(dot)org> wrote:
>
> On Fri, Oct 3, 2014 at 2:15 AM, Marti Raudsepp <marti(at)juffo(dot)org> wrote:
> > + ereport(NOTICE,
> > + (errcode(ERRCODE_DUPLICATE_TABLE),
> > + errmsg("relation \"%s\" already exists, skipping",
> > + indexRelationName)));
> >
> > 1. Clearly "relation" should be "index".
> > 2. Use ERRCODE_DUPLICATE_OBJECT not TABLE
>
> My bad, this code is OK. The current code already uses "relation" and
> TABLE elsewhere because indexes share the same namespace with tables.
>

Ok. I reply it in other message.

> + /*
> + * Throw an exception when IF NOT EXISTS is used without a named
> + * index
> + */
>
> I'd say "without an index name". And the line goes beyond 80 characters
wide.
>

Fixed and send in other reply...

> I would also move this check to after all the attributes have been
> assigned, rather than splitting the assignments in half.
>

Why? If you see other places in gram.y it's a common usage...

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello