Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "[pgdg] Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
Subject: Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements
Date: 2014-10-03 02:38:58
Message-ID: CAFcNs+qTrW04pegxtjptkX=3dLDgwXaM+UctfKmnD0AmQyc8AQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 2, 2014 at 9:38 PM, Marti Raudsepp <marti(at)juffo(dot)org> wrote:
>
> On Tue, Aug 26, 2014 at 4:20 PM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
> > On 04/14/2014 10:31 PM, Fabrízio de Royes Mello wrote:
> >> The attached patch contains CINE for sequences.
> >>
> >> I just strip this code from the patch rejected before.
> >
> > Committed with minor changes
>
> Hmm, the CommitFest app lists Marko Tiikkaja as the reviewer, but I
> can't find his review anywhere...
>

Maybe he have no time to review it.

> The documentation claims:
> CREATE [ IF NOT EXISTS ] SEQUENCE name
> But grammar implements it the other way around:
> CREATE SEQUENCE IF NOT EXISTS name;
>

You are correct. Fix attached.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

Attachment Content-Type Size
fix_create_sequence_doc_v1.patch text/x-diff 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2014-10-03 03:07:36 Re: DDL Damage Assessment
Previous Message Tom Lane 2014-10-03 02:08:16 Re: TAP test breakage on MacOS X