From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: psql \d+ and oid display |
Date: | 2014-03-28 18:53:32 |
Message-ID: | CAFcNs+pn1RAr3uQQCgSDjwikMyE9MtjGHNDMHwucxfg-k+FOtw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 28, 2014 at 3:41 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > On Thu, Mar 27, 2014 at 02:54:26PM -0400, Stephen Frost wrote:
> >> I believe Bruce was suggesting to show it when it is set to *not* the
> >> default, which strikes me as perfectly reasonable.
>
> > We seem to be split on the idea of having "Has OIDs" display only when
> > the oid status of the table does not match the default_with_oids
> > default.
>
> FWIW, I think that having the display depend on what that GUC is set to
> is a seriously *bad* idea. It will mean that you don't actually know,
> when looking at the output of \d, whether the table has OIDs or not.
>
> I could get behind a proposal to suppress the line when there are not
> OIDs, full stop; that is, we print either "Has OIDs: yes" or nothing.
> But I think this patch just makes things even more surprising when
> default_with_oids is turned on.
>
Something like the attached ?
Grettings,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
Attachment | Content-Type | Size |
---|---|---|
display_oids_v1.patch | text/x-diff | 632 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2014-03-28 19:45:02 | Re: psql \d+ and oid display |
Previous Message | Tom Lane | 2014-03-28 18:41:02 | Re: psql \d+ and oid display |