fix worker_spi to run as non-dynamic background worker

From: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: fix worker_spi to run as non-dynamic background worker
Date: 2014-05-23 09:29:55
Message-ID: CAEZqfEe-VzqrQuScNsBO3XgV8rRj0Mp-cvbxmnQb1kVUryxXDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I noticed that contrib/worker_spi can't run as non-dynamic background
worker (IOW, load via shared_preload_libraries), because of
uninitialized bgw_notify_pid.

I got log lines below when starting PostgreSQL with
shared_preload_libraries = 'worker_spi'.

$ pg_ctl start -w
waiting for server to start....LOG: registering background worker "worker 1"
LOG: background worker "worker 1": only dynamic background workers
can request notification
LOG: registering background worker "worker 2"
LOG: background worker "worker 2": only dynamic background workers
can request notification
LOG: redirecting log output to logging collector process
HINT: Future log output will appear in directory "pg_log".

Attached patch fixes this issue. Please apply onto HEAD and 9.4.

--
Shigeru HANADA

Attachment Content-Type Size
fix_worker_spi.patch application/octet-stream 470 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sandro Santilli 2014-05-23 11:09:07 postgres_fdw and connection management
Previous Message Dilip kumar 2014-05-23 08:28:56 Re: Allowing join removals for more join types