| From: | Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
|---|---|
| To: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
| Cc: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>, Jim Mlodgenski <jimmy76(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: [v9.5] Custom Plan API |
| Date: | 2014-07-15 11:09:01 |
| Message-ID: | CAEZqfEc-hr0gSKOJi4KgBEg1P3_HZPvgRRvMKhqFEFBZTh+edQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kaigai-san,
2014-07-14 22:18 GMT+09:00 Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>:
> Hanada-san,
>
> Thanks for your checking. The attached v4 patch is rebased one on the
> latest master branch. Indeed, merge conflict was trivial.
>
> Updates from the v3 are below:
> - custom-plan.sgml was renamed to custom-plan-provider.sgml
> - fix up the comments in pg_custom_plan_provider.h that mentioned
> about old field name.
> - applied your patch to fix up typos. (thanks so much!)
> - put "costs off" on the EXPLAIN command in the regression test of
> ctidscan extension.
Checked, but the patch fails sanity-check test, you need to modify
expected file of the test.
> Nothing to comment on the design and implementation from your
> viewpoint any more?
As much as I can tell, the design seems reasonable. After fix for the
small issue above, I'll move the patch status to "Ready for
committer".
--
Shigeru HANADA
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2014-07-15 11:46:27 | Re: Removing dependency to wsock32.lib when compiling code on WIndows |
| Previous Message | Fujii Masao | 2014-07-15 10:38:38 | Re: timeout of pg_receivexlog --status-interval |