| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, PostGreSql hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: array_length(anyarray) |
| Date: | 2014-01-20 13:29:42 |
| Message-ID: | CAEZATCW8ugtwzEHPT06BLKpA+HpuARkxd3g0o+-fkKrpF53dNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19 January 2014 11:43, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> New version attached, without the doc change.
>
This looks good to me.
- applies cleanly.
- compiles with no warnings.
- passes a sensible set of new regression tests.
- implements the agreed behaviour, per SQL spec.
- I can't think of any corner cases to break it.
I think this is ready for committer, although I would also like to see
the doc changes to make the table of array function descriptions a bit
more explicit about corner cases.
Also, does this mean that we can now claim full support for SQL
feature S091 "Basic array support"?
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Layton | 2014-01-20 13:43:34 | Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance |
| Previous Message | Stephen Frost | 2014-01-20 13:24:36 | Re: ALTER TABLESPACE ... MOVE ALL TO ... |