Re: [PATCH] Negative Transition Aggregate Functions (WIP)

On 26 March 2014 19:43, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Thu, Mar 27, 2014 at 7:33 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
>> > I've attached an updated invtrans_strictstrict_base patch which has the
>> > feature removed.
>>
>> What is the state of play on this patch? Is the latest version what's in
>>
>> http://www.postgresql.org/message-id/64F96FD9-64D1-40B9-8861-E6182029220B@phlo.org
>> plus this sub-patch? Is everybody reasonably happy with it? I don't
>> see it marked "ready for committer" in the CF app, but time is running
>> out.
>>
>
> As far as I know the only concern left was around the extra stats in the
> explain output, which I removed in the patch I attached in the previous
> email.
>

Agreed. That was my last concern regarding the base patch, and I agree
that removing the new explain output is probably the best course of
action, given that we haven't reached consensus as to what the most
useful output would be.

> The invtrans_strictstrict_base.patch in my previous email replaces the
> invtrans_strictstrict_base_038070.patch in that Florian sent here
> http://www.postgresql.org/message-id/64F96FD9-64D1-40B9-8861-E6182029220B@phlo.org
> all of the other patches are unchanged so it's save to use Florian's latest
> ones
>
> Perhaps Dean can confirm that there's nothing else outstanding?
>

Florian mentioned upthread that the docs hadn't been updated to
reflect the latest changes, so I think they need a little attention.

Regards,
Dean