From: | Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Stephen Frost <sfrost(at)snowman(dot)net>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Ants Aasma <ants(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
Subject: | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |
Date: | 2013-02-24 20:08:33 |
Message-ID: | CAEYLb_XAx_CPVexVciazZ=2k7WvUVnJuETioWZwaFXpuMK58YQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 24 February 2013 08:44, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> wrote:
> I can't speak for others, but I personally don't care whether a patch is
> posted in unified or context diff format. Not as a general rule, anyway;
> patches that modify a few lines here and there are generally more readable
> in unified format, as the old and new lines are lined up right next to each
> other:
I don't care either. My personal preference is context diff format,
but then that's what I usually see anyway. I don't use filterdiff or
anything like that. I just have a strong habit of using feature
branches extensively, even for patches that I'm reviewing, and my
setup makes that easy to create from a patch file. It's quite a rare
occurrence for me to care enough about a patch to want to eyeball the
code (and not just read the author's summary), and yet not care about
it enough to make a feature branch for it. I can see how other
people's habits might differ from my own here, and that they might
reasonably state a preference for unified, which is fine. I developed
a preference for unified over time, having originally just used the
format on the advice of the wiki.
--
Regards,
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2013-02-24 20:46:37 | Re: [DOCS] Contrib module "xml2" status |
Previous Message | Andrew Dunstan | 2013-02-24 19:42:02 | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |