Re: Potential NULL dereference found in typecmds.c

From: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Michael Mueller <mmueller(at)vigilantsw(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Potential NULL dereference found in typecmds.c
Date: 2011-07-04 13:07:30
Message-ID: CAEYLb_Vw8c=a0menxRbbKpZhiUAnWjq3ATdU0TVv5xdZUVJAmg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4 July 2011 13:53, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> This code is no longer present in git head, *removed* by commit
> 426cafc. Not added by it. at least that's how I read the history...
>
> However, it still looks to me like we could get to that code with
> con=NULL - if the while loop is never executed. Perhaps this is a
> can-never-happen situation? Alvaro?

Seems slightly academic IMHO. No code path should dereference an
invariably NULL or wild pointer.

--
Peter Geoghegan       http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2011-07-04 13:14:11 Re: Potential NULL dereference found in typecmds.c
Previous Message Magnus Hagander 2011-07-04 12:53:06 Re: Potential NULL dereference found in typecmds.c