Re: sortsupport for text

From: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: sortsupport for text
Date: 2012-07-23 16:07:18
Message-ID: CAEYLb_Vt+4RheQUAoGcxNyj+LCozMka+dnvMzmfegPkj8v+mWQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23 July 2012 16:36, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Jul 23, 2012 at 11:34 AM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
>>> tss->buflen = 1 << ffs(len1);
>>
>> I'm sorry, I don't follow you here. What is ffs() ?
>
> Sorry, fls, not ffs. I always get those mixed up.
>
> See src/port/fls.c

Oh, okay. Since, I infer, we're starting from a buffer-size that's a
power-of-two anyway, is there really any advantage in doing this
rather than just doubling the buffer size each time?

--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-07-23 16:09:14 Re: sortsupport for text
Previous Message Robert Haas 2012-07-23 15:36:56 Re: sortsupport for text