Re: Add more regression tests for CREATE OPERATOR

From: Robins Tharakan <tharakan(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Szymon Guz <mabewlun(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add more regression tests for CREATE OPERATOR
Date: 2013-06-27 14:12:10
Message-ID: CAEP4nAzsGK4ba1y8FTR42HkEmbdbaCx_JLNp6AiChZsrCkN-Fw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sure Robert.
I 'll update the tests and get back.

Two questions, while we're at it:

1. Any other conventions (for naming)?
2. Should I assume that all database objects that get created, need to be
dropped explicitly? Or is this point specifically about ROLES?

--
Robins Tharakan

On 27 June 2013 09:00, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Wed, Jun 26, 2013 at 3:29 AM, Szymon Guz <mabewlun(at)gmail(dot)com> wrote:
> > OK, so I think this patch can be committed, I will change the status.
>
> We have a convention that roles created by the regression tests needs
> to have "regress" or something of the sort in the name, and that they
> need to be dropped by the regression tests. The idea is that if
> someone runs "make installcheck" against an installed server, it
> should pass - even if you run it twice in succession. And also, it
> shouldn't be likely to try to create (and then drop!) a role name that
> already exists.
>
> Setting this to "Waiting on Author".
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-06-27 14:12:42 Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]
Previous Message Tom Lane 2013-06-27 14:05:34 Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]