Re: [BUGS] BUG #9652: inet types don't support min/max

Thank you Haribabu. Please see my comments inlined below i.e.

On Sun, Jul 27, 2014 at 11:42 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
wrote:

> On Thu, Jul 24, 2014 at 5:59 PM, Asif Naeem <anaeem(dot)it(at)gmail(dot)com> wrote:
> > Sorry for being late. Thank you for sharing updated patch, sgml changes
> > seems not working i.e.
> >
> >> postgres=# select max('192.168.1.5', '192.168.1.4');
> >> ERROR: function max(unknown, unknown) does not exist
> >> LINE 1: select max('192.168.1.5', '192.168.1.4');
> >>
> >> ^
> >> HINT: No function matches the given name and argument types. You might
> >> need to add explicit type casts.
> >> postgres=# select min('192.168.1.5', '192.168.1.4');
> >> ERROR: function min(unknown, unknown) does not exist
> >> LINE 1: select min('192.168.1.5', '192.168.1.4');
> >>
> >> ^
> >> HINT: No function matches the given name and argument types. You might
> >> need to add explicit type casts.
>
> I didn't get your point. I tested the patch, the sgml changes are working
> fine.

Sorry for not being clear, above mentioned test is related to following doc
(sgml) changes that seems not working as described i.e.

*Table 9-35. cidr and inet Functions*
FunctionReturn TypeDescriptionExampleResult

max(inet, inet)inetlarger of two inet typesmax('192.168.1.5', '192.168.1.4')
192.168.1.5min(inet, inet)inetsmaller of two inet typesmin('192.168.1.5',
'192.168.1.4')192.168.1.4

Can you please elaborate these sgml change ?

> > I would suggest the following or similar changes e.g.
> >
> >> doc/src/sgml/func.sgml
> >> </indexterm>
> >> <function>max(<replaceable
> >> class="parameter">expression</replaceable>)</function>
> >> </entry>
> >> - <entry>any array, numeric, string, or date/time type</entry>
> >> + <entry>any inet, array, numeric, string, or date/time
> type</entry>
> >> <entry>same as argument type</entry>
> >> <entry>
> >> maximum value of <replaceable
> >> @@ -12204,7 +12228,7 @@ NULL baz</literallayout>(3 rows)</entry>
> >> </indexterm>
> >> <function>min(<replaceable
> >> class="parameter">expression</replaceable>)</function>
> >> </entry>
> >> - <entry>any array, numeric, string, or date/time type</entry>
> >> + <entry>any inet, array, numeric, string, or date/time
> type</entry>
> >> <entry>same as argument type</entry>
> >> <entry>
> >> minimum value of <replaceable
>
> Thanks for reviewing the patch.
> I missed the above change. Corrected the same in the attached patch.
>
> Regards,
> Hari Babu
> Fujitsu Australia
>