From: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
---|---|
To: | Shigeru HANADA <shigeru(dot)hanada(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Move postgresql_fdw_validator into dblink |
Date: | 2012-10-09 11:20:44 |
Message-ID: | CADyhKSU+G2F5yXoKC7MyGzSo4_zS-fQA6uwXGhiYM6-w-aFf6w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hanada-san,
It is fair enough for me.
So, I'd like to hand over this patch for committers.
Thanks,
2012/10/9 Shigeru HANADA <shigeru(dot)hanada(at)gmail(dot)com>:
> (2012/10/09 0:30), Kohei KaiGai wrote:
>>
>> The attached patch is a revised one according to my previous
>> suggestion. It re-defines "PQconninfoOption *options" as static
>> variable with NULL initial value, then, PQconndefaults() shall
>> be invoked at once. The default options never changed during
>> duration of the backend process, so here is no reason why we
>> allocate and free this object for each validator invocation.
>
>
> Sorry for delayed response. It seems reasonable, so I just fixed obsolete
> comment and indent. Please see attached v3 patch which was rebased against
> latest head of master.
>
>
>> If it is also OK for you, I'd like to take over this patch to comitter.
>> This patch is prerequisite of postgresql_fdw, so I hope this patch
>> getting merged soon.
>
>
> Please go ahead. :-)
>
> Regards,
> --
> Shigeru HANADA
>
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
From | Date | Subject | |
---|---|---|---|
Next Message | Vik Reykja | 2012-10-09 12:16:13 | Re: Truncate if exists |
Previous Message | Daniel Farina | 2012-10-09 10:05:34 | Re: Detecting libpq connections improperly shared via fork() |